Conversation
This was referenced Jan 26, 2026
mkadirtan
approved these changes
Jan 26, 2026
lewisdaly
requested changes
Jan 28, 2026
lewisdaly
left a comment
lewisdaly
left a comment
There was a problem hiding this comment.
I think we should use the original transfer amount than amount_max across all exercises to keep things simple.
exercises/024_two_phase_transfers.sh
Outdated
|
|
||
| # Now we can execute or "post" the transfer: | ||
| tb "create_transfers id=24000 pending_id=24000 flags=post_pending_transfer;" | ||
| tb "create_transfers id=24000 pending_id=24000 amount=$amount_max flags=post_pending_transfer;" |
There was a problem hiding this comment.
We can do amount_max, or simply the same amount of the original transfer - 200. I think 200 is easier in this case since we don't need to introduce a new concept.
toziegler
force-pushed
the
tobi/fix_bunch
branch
from
79efa83 to
f6e7ea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple small issues.