Add Config class for Ziggy configuration management (dynamic configuration)#857
Closed
thaqebon wants to merge 2 commits intotighten:2.xfrom
Closed
Add Config class for Ziggy configuration management (dynamic configuration)#857thaqebon wants to merge 2 commits intotighten:2.xfrom
thaqebon wants to merge 2 commits intotighten:2.xfrom
Conversation
- Added static methods to Config for setting and getting default configurations. - Updated Route and Router classes to utilize the new Config. - Added tests to validate new Config class.
Collaborator
|
Thanks a lot for the PR, and for your patience! This is really interesting but I think I'm going to pass for now. It's a lot of new code to introduce and I'm not sure that this pattern is super common or necessarily something we want to push people towards. I can see how it could be helpful to eventually have something a bit more polished than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configclass to manage Ziggy configuration.set(),get()andabsolute()methods for default configuration.RouteandRouterclasses to use the newConfigclass.Purpose
The main goal of this PR is to allow dynamic configuration of Ziggy at runtime by setting a config getter:
This makes Ziggy more flexible by allowing dynamic configuration instead of relying on a static one.