fix(flatpak): Add Slack URL scheme support for OAuth flow#1651
Open
jkuro-tii wants to merge 1 commit intotiiuae:mainfrom
Open
fix(flatpak): Add Slack URL scheme support for OAuth flow#1651jkuro-tii wants to merge 1 commit intotiiuae:mainfrom
jkuro-tii wants to merge 1 commit intotiiuae:mainfrom
Conversation
- Implement slack:// URL handling within the Flatpak VM - Ensure Slack launches correctly with authorization links Slack OAuth login now works end-to-end, allowing authorization links to properly open inside the Flatpak sandbox instead of failing or looping. Signed-off-by: jkuro-tii <jaroslaw.kurowski@tii.ae>
Collaborator
|
I have a design question regarding this PR. Do we need to support Slack through the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack OAuth login now works end-to-end, allowing authorization links to properly open inside the Flatpak sandbox instead of failing or looping.
Description of Changes
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: