#2374 move some dependencies to private #2376
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiksn
reviewed
Jun 24, 2025
Owner
|
How about rest of the dev dependencies like Also, this PR will not close #2374 because PowerShell scripts need to be updated, in order not to include dev dependencies to NuGet dependencies. Please include those changes, or remove "Closes" comment so that I will make those changes and will complete #2374 |
Author
|
ah ok, didn't realise the custom compilation of nuspec files which explains the root of the issue. Note i had not changed github dependency as the privateAssets would normally been sufficient. Description has been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #2374
Scripts need to be updated to enable closing issue