Skip to content

Log region ranges on "failed to decode region range key" error (#1678) #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilbi123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Log region ranges on "failed to decode region range key" error (#1678) #1685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .vs/slnx.sqlite
View file
Open in desktop
Binary file not shown.
Binary file added .vs/slnx.sqlite-journal
View file
Open in desktop
Binary file not shown.
13 changes: 9 additions & 4 deletions internal/locate/region_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2224,8 +2224,8 @@ func (c *RegionCache) scanRegions(bo *retry.Backoffer, startKey, endKey []byte,
metrics.LoadRegionCacheHistogramWithRegions.Observe(time.Since(start).Seconds())
if err != nil {
if apicodec.IsDecodeError(err) {
return nil, errors.Errorf("failed to decode region range key, limit: %d, err: %v",
limit, err)
return nil, errors.Errorf("failed to decode region range key, limit: %d, startKey: %q, endKey: %q, err: %v",
limit, redact.Key(startKey), redact.Key(endKey), err)
}
metrics.RegionCacheCounterWithScanRegionsError.Inc()
backoffErr = errors.Errorf(
Expand Down Expand Up @@ -2299,9 +2299,14 @@ func (c *RegionCache) batchScanRegions(bo *retry.Backoffer, keyRanges []router.K
return c.batchScanRegionsFallback(bo, keyRanges, limit, opts...)
}
if apicodec.IsDecodeError(err) {
return nil, errors.Errorf("failed to decode region range key, range num: %d, limit: %d, err: %v",
len(keyRanges), limit, err)
var b strings.Builder
for i, kr := range keyRanges {
fmt.Fprintf(&b, "[%d] start: %q, end: %q; ", i, redact.Key(kr.StartKey), redact.Key(kr.EndKey))
}
return nil, errors.Errorf("failed to decode region range key, range num: %d, limit: %d, keyRanges: %s, err: %v",
len(keyRanges), limit, b.String(), err)
}

metrics.RegionCacheCounterWithBatchScanRegionsError.Inc()
backoffErr = errors.Errorf(
"batchScanRegion from PD failed, range num: %d, limit: %d, err: %v",
Expand Down