Skip to content

CheckNotExists is checked in the prewrite phase and should not appear in the commit phase. #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CheckNotExists is checked in the prewrite phase and should not appear in the commit phase. #316

wants to merge 2 commits into from
+7 −0

Conversation

gfreezy
Copy link
Contributor

@gfreezy gfreezy commented Aug 24, 2021 •
edited
Loading

fixed #315

When we set the primary key of a transaction, the corresponding operation must not be CheckNotExists.

@ekexium CheckNotExists is already checked when set primary key.

@gfreezy gfreezy force-pushed the fix-check-not-exists branch from 1d31029 to 3fe6267 Compare August 24, 2021 06:43
@ekexium
Copy link
Collaborator

ekexium commented Aug 24, 2021

The change itself looks good to me.

I'd prefer to fix the primary key issue and add a test in the same PR to close #315 .

@andylokandy
Copy link
Collaborator

Can we merge it now?

@ekexium
Copy link
Collaborator

ekexium commented Dec 7, 2021

I think a test case is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TxnLockNotFound
3 participants
@gfreezy @ekexium @andylokandy