Skip to content

CheckNotExists is checked in the prewrite phase and should not appear in the commit phase. #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CheckNotExists is checked in the prewrite phase and should not appear in the commit phase. #316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fe6267
CheckNotExists is checked in the prewrite phase and should not appear…
gfreezy Aug 24, 2021
b481480
Merge branch 'master' into fix-check-not-exists
andylokandy Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/transaction/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,6 +1139,11 @@ struct Committer<PdC: PdClient = PdRpcClient> {
}

impl<PdC: PdClient> Committer<PdC> {
// CheckNotExists is checked in the prewrite phase and should not appear in the commit phase.
fn filter_out_check_not_exists_mutations(&mut self) {
self.mutations.retain(|m| m.op() != Op::CheckNotExists)
}

async fn commit(mut self) -> Result<Option<Timestamp>> {
debug!("committing");

Expand All @@ -1155,6 +1160,8 @@ impl<PdC: PdClient> Committer<PdC> {
return Ok(min_commit_ts);
}

self.filter_out_check_not_exists_mutations();

let commit_ts = if self.options.async_commit {
// FIXME: min_commit_ts == 0 => fallback to normal 2PC
min_commit_ts.unwrap()
Expand Down