Skip to content

[DNM] Req debug log #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: cse
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/request/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ mod shard;
#[async_trait]
pub trait KvRequest: Request + Sized + Clone + Sync + Send + 'static {
/// The expected response to the request.
type Response: HasKeyErrors + HasLocks + Clone + Send + 'static;
type Response: HasKeyErrors + HasLocks + Clone + Send + std::fmt::Debug + 'static;

// TODO: fn encode_request()
// TODO: fn decode_response()
Expand Down Expand Up @@ -114,7 +114,7 @@ mod test {

#[tokio::test]
async fn test_region_retry() {
#[derive(Clone)]
#[derive(Clone, Debug)]
struct MockRpcResponse;

impl HasKeyErrors for MockRpcResponse {
Expand Down
12 changes: 10 additions & 2 deletions src/request/plan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ impl<Req: KvRequest> Plan for Dispatch<Req> {

async fn execute(&self) -> Result<Self::Result> {
let stats = tikv_stats(self.request.label());
if self.request.label() == "kv_prewrite" || self.request.label() == "kv_commit" {
info!("req {}", self.request.to_str())
}
let result = self
.kv_client
.as_ref()
Expand All @@ -70,8 +73,13 @@ impl<Req: KvRequest> Plan for Dispatch<Req> {
.await;
let result = stats.done(result);
result.map(|r| {
*r.downcast()
.expect("Downcast failed: request and response type mismatch")
let resp = *r
.downcast()
.expect("Downcast failed: request and response type mismatch");
if self.request.label() == "kv_prewrite" || self.request.label() == "kv_commit" {
info!("resp {:?}", resp);
}
resp
})
}
}
Expand Down
7 changes: 7 additions & 0 deletions src/store/request.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ pub trait Request: Any + Sync + Send + 'static {
/// Should always use `set_context` other than modify the `self.context` directly.
fn set_context(&mut self, context: kvrpcpb::Context);
fn set_api_version(&mut self, api_version: kvrpcpb::ApiVersion);
fn to_str(&self) -> String {
"".to_string()
}
}

macro_rules! impl_request {
Expand Down Expand Up @@ -68,6 +71,10 @@ macro_rules! impl_request {
let context = self.context.get_or_insert(kvrpcpb::Context::default());
context.api_version = api_version.into();
}

fn to_str(&self) -> String {
format!("{:?}", self)
}
}
};
}
Expand Down
Loading