Open
Conversation
Signed-off-by: TXXT <hunterlxt@live.com>
Member
Author
|
I think all the tests need to be updated, It is better to test in the form of |
Member
Author
|
@BusyJay I think this PR is ready PTAL |
08942e2 to
86f06ca
Compare
Signed-off-by: TXXT <hunterlxt@live.com>
Signed-off-by: TXXT <hunterlxt@live.com>
Member
|
@NingLin-P PTAL |
NingLin-P
reviewed
May 29, 2020
NingLin-P
reviewed
Jun 1, 2020
NingLin-P
previously approved these changes
Jun 1, 2020
BusyJay
reviewed
Jun 1, 2020
Signed-off-by: Xintao <hunterlxt@live.com>
NingLin-P
reviewed
Jun 2, 2020
BusyJay
reviewed
Jun 2, 2020
Member
BusyJay
left a comment
There was a problem hiding this comment.
I suggest to use the patch inside TiKV if the interfaces are good enough to write clean code. As far as what I can see, it's hard to build thread group without a FailPointRegistry::current method.
Signed-off-by: Xintao <hunterlxt@live.com>
Signed-off-by: Xintao <hunterlxt@live.com>
Member
Author
|
This PR is staled for about a week |
Member
|
So have you tried to use it in TiKV? Is everything working well? |
Member
Author
Signed-off-by: Xintao <hunterlxt@live.com>
Signed-off-by: Xintao <hunterlxt@live.com>
Signed-off-by: Xintao <hunterlxt@live.com>
BusyJay
reviewed
Jul 30, 2020
Signed-off-by: Xintao <hunterlxt@live.com>
BusyJay
reviewed
Aug 3, 2020
Signed-off-by: Xintao <hunterlxt@live.com>
Signed-off-by: Xintao <hunterlxt@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let multiple tests run over different threads, meanwhile each configuration doesn't affect others.
FailPointRegistryas local registry.pub fn create_registry() -> FailPointRegistrycan get a newFailPointRegistry. So we can bound threads into exact one registry withregister_current(&self)andderegister_current(&self).close #51