[WIP] add server instrumentation for calls#294
Open
fbandersnatch wants to merge 3 commits intotikv:masterfrom
Open
[WIP] add server instrumentation for calls#294fbandersnatch wants to merge 3 commits intotikv:masterfrom
fbandersnatch wants to merge 3 commits intotikv:masterfrom
Conversation
a8268aa to
c81811b
Compare
Member
|
Nice job! We planed to do this long time ago but still not get the time to make it really happen. Really excited to see someone can pick it up finally! The underlying architecture of grpcio is very similar to the C# implementation. So you can refer to the similar proposal and its implementation at grpc/proposal#38. |
Author
|
Cool, I'll look at their implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to enable user-pluggable functionality to run on every request. The goal is to use it for logging and monitoring e.g., I'll use it for request counts, request rates and processing time counters.
This commit has a simple no-op example to achieve this.
Usage:
Implement
trait ServerInstrumenterwith the needed instrumentation, asMyServiceInstrumenter.WIP:
This is still work in progress, I'm open to feedback on this
Are there plans to implement such use cases in other ways?