fix benchmark build fail and test fail #664 #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DogDu <[email protected]>
|
Welcome @Dog-Du! It looks like this is your first PR to tikv/grpc-rs 🎉 |
Signed-off-by: DogDu <[email protected]>
Dog-Du
changed the title
Signed-off-by: DogDu <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
dco-signoff: no
and removed
dco-signoff: no
dco-signoff: yes
labels
Signed-off-by: DogDu <[email protected]>
Signed-off-by: DogDu <[email protected]>
overvenus
reviewed
Jul 30, 2025
Comment on lines
+27
to
+31
| #[arg(id = "driver_port", long)] | ||
| driver_port0: Option<u16>, | ||
| /// The port the worker should listen on. For example, 8080 | ||
| #[arg(id = "driver-port", long)] | ||
| driver_port1: Option<u16>, |
There was a problem hiding this comment.
Why add a new port? what's difference between driver_port and driver-port?
There was a problem hiding this comment.
No difference, only one of them is not None, just to support both --driver-port and --driver_port.
we need --driver_port when running python3 tools/run_tests/run_performance_tests.py -l rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close issue: #664
build benchmark fail.
we need to add
derivefeature when importingclapbenchmark test fail.
we need to add the argument
--driver_port