Skip to content

Conversation

@SerjKol80
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #9855

What is changed and how does it work?

Add 'store' label to metric pd_cluster_status in 7.5.

Check List

Tests

  • Unit test

Code changes

  • Code now emit Gauge metric pd_cluster_status for each store separately and adds label 'store' containing storeId. Previously code aggregated this metric across all stores and then emitted one time.

Side effects

  • metric pd_cluster_status now needs to be aggregated in metic system across all stores if you need value across whole cluster.

Related changes

None

Release note

We added 'store' label to metric pd_cluster_status. This new label contains store ID for which datapoint is emitted. How if you still need the value from this metric for the whole cluster, then you need to aggregate it across all stores

Signed-off-by: Sergey Kolosov sergey.kolosov@airbnb.com

Co-authored-by: Sergey Kolosov sergey.kolosov@airbnb.com
(cherry picked from commit b0500cd)
Signed-off-by: Sergey Kolosov sergey.kolosov@airbnb.com

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 13, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2025

Hi @SerjKol80. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2025
@SerjKol80 SerjKol80 changed the title Add 'store' label to metric pd_cluster_status in 8.5. (#9865) Add 'store' label to metric pd_cluster_status in 7.5. (#9865) Dec 13, 2025
close tikv#9855

Add 'store' label to metric pd_cluster_status in 8.5.

Signed-off-by: Sergey Kolosov <sergey.kolosov@airbnb.com>

Co-authored-by: Sergey Kolosov <sergey.kolosov@airbnb.com>
(cherry picked from commit b0500cd)
Signed-off-by: Sergey Kolosov <sergey.kolosov@airbnb.com>
@SerjKol80 SerjKol80 force-pushed the sergey-kolosov/store-metrics branch from 44c380b to 43e7ecd Compare January 7, 2026 19:50
@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 8, 2026
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-22 01:59:26.225580977 +0000 UTC m=+631993.839537834: ☑️ agreed by bufferflies.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2026
@bufferflies bufferflies requested a review from okJiang January 22, 2026 02:22
@bufferflies
Copy link
Contributor

/retest

Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,22 @@
// Copyright 2020 TiKV Project Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2020 TiKV Project Authors.
// Copyright 2026 TiKV Project Authors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not do it on cherry-picking but on main branch.

@v01dstar
Copy link
Member

Please also pick this https://github.com/tikv/pd/pull/9945/changes

This is not approved for cherry-picking, should we include it? @okJiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants