-
Notifications
You must be signed in to change notification settings - Fork 754
Add 'store' label to metric pd_cluster_status in 7.5. (#9865) #10060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-7.5
Are you sure you want to change the base?
Conversation
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @SerjKol80. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
44c380b to
43e7ecd
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
okJiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also pick this https://github.com/tikv/pd/pull/9945/changes
| @@ -0,0 +1,22 @@ | |||
| // Copyright 2020 TiKV Project Authors. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Copyright 2020 TiKV Project Authors. | |
| // Copyright 2026 TiKV Project Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not do it on cherry-picking but on main branch.
This is not approved for cherry-picking, should we include it? @okJiang |
What problem does this PR solve?
Issue Number: Close #9855
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
None
Release note
Signed-off-by: Sergey Kolosov sergey.kolosov@airbnb.com
Co-authored-by: Sergey Kolosov sergey.kolosov@airbnb.com
(cherry picked from commit b0500cd)
Signed-off-by: Sergey Kolosov sergey.kolosov@airbnb.com