Skip to content

Conversation

@liupan1111
Copy link
Contributor

…g primary

What problem does this PR solve?

Issue Number: Close #9776

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 20, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign binshi-bing for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2025

Hi @liupan1111. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2025
@liupan1111 liupan1111 changed the title scheduling: fixed schedulersUpdatingNotifier may block after switchin… scheduling: fixed the scheduling server may be blocked after switching primary Dec 20, 2025
@rleungx
Copy link
Member

rleungx commented Dec 22, 2025

/cc @JmPotato

@ti-chi-bot ti-chi-bot bot requested a review from JmPotato December 22, 2025 02:50
…g primary

Signed-off-by: Pan Liu <liupan1111@gmail.com>
@liupan1111
Copy link
Contributor Author

/label

@liupan1111
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 24, 2025

@liupan1111: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liupan1111
Copy link
Contributor Author

@liupan1111: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

@rleungx pls help take look.

@rleungx
Copy link
Member

rleungx commented Dec 24, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 24, 2025
@rleungx
Copy link
Member

rleungx commented Dec 24, 2025

@liupan1111: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
Details

@rleungx pls help take look.

done

@liupan1111
Copy link
Contributor Author

/retest

@liupan1111
Copy link
Contributor Author

/test pull-unit-test-next-gen-3

1 similar comment
@liupan1111
Copy link
Contributor Author

/test pull-unit-test-next-gen-3

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 24, 2025

@liupan1111: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-3 ab6ed8e link true /test pull-unit-test-next-gen-3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@liupan1111
Copy link
Contributor Author

new added testcase \TestPrimarySwitchWithInflightConfigChange\ failed, let me investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schedulersUpdatingNotifier may block after switching primary

3 participants