-
Notifications
You must be signed in to change notification settings - Fork 754
metrics: add slow store scheduler status graph to Grafana dashboard (#9941) #9980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: add slow store scheduler status graph to Grafana dashboard (#9941) #9980
Conversation
Signed-off-by: okjiang <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9980 +/- ##
==========================================
+ Coverage 78.54% 78.57% +0.03%
==========================================
Files 520 520
Lines 69676 69676
==========================================
+ Hits 54724 54750 +26
+ Misses 10994 10980 -14
+ Partials 3958 3946 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/retest |
…9941-to-master
📝 WalkthroughWalkthroughA new Grafana dashboard panel was added to monitor slow store scheduler metrics. The panel displays status information using a PromQL query targeting the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
metrics/grafana/pd.json (1)
7913-8004: Addstorefilter to align with dashboard patterns and avoid high-cardinality graphs.The PromQL query omits the
$storevariable filter used consistently across 30+ other scheduler panels in this dashboard. This creates unnecessary cardinality on large clusters and deviates from established conventions. The metricpd_scheduler_evicted_slow_store_statusexportsstoreandslow_typelabels, so the filter is supported.Proposed fix
- "expr": "pd_scheduler_evicted_slow_store_status{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\"}", + "expr": "pd_scheduler_evicted_slow_store_status{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", store=~\"$store\"}",
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
metrics/grafana/pd.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: chunks
- GitHub Check: chunks (6, Tools Test)
- GitHub Check: chunks (7, Client Integration Test)
- GitHub Check: statics
- GitHub Check: chunks (10, Microservice Integration(TSO))
- GitHub Check: chunks (9, Microservice Integration(!TSO))
- GitHub Check: chunks (8, TSO Integration Test)
- GitHub Check: chunks (3, Unit Test(3))
- GitHub Check: chunks (4, Tests(1))
- GitHub Check: chunks (1, Unit Test(1))
- GitHub Check: chunks (5, Tests(2))
- GitHub Check: chunks (2, Unit Test(2))
- GitHub Check: tso-function-test
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… dashboard (tikv#9941) (tikv#9980) close tikv#9866 Signed-off-by: okjiang <[email protected]> Co-authored-by: okjiang <[email protected]>
… dashboard (tikv#9941) (tikv#9980) close tikv#9866 Signed-off-by: okjiang <[email protected]> Co-authored-by: okjiang <[email protected]>
This is an automated cherry-pick of #9941
What problem does this PR solve?
Issue Number: Close #9866
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.