Skip to content

Conversation

realchonk
Copy link

This makes pprof-rs compile, but the generated flamegraphs are total garbage (at least for fuse-ufs).

Copy link

ti-chi-bot bot commented Feb 25, 2025

Welcome @realchonk! It looks like this is your first PR to tikv/pprof-rs 🎉

Copy link

ti-chi-bot bot commented Feb 25, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@YangKeao
Copy link
Member

YangKeao commented Feb 26, 2025

Thanks for your contribution 🍻 .

Please sign-off your commit: you can use git commit -s --amend and git push -f to sign off your previous commit.

@YangKeao
Copy link
Member

but the generated flamegraphs are total garbage

Let me find an OpenBSD and try to locate the issue 🤦 .

@jmmv
Copy link

jmmv commented Apr 12, 2025

Oh, also see: #265

I found the same issue where the profiles make no sense for complex apps... but as I mentioned in that PR, they seem OK for a trivial toy program. Not sure what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants