Skip to content

Bump pprof to 0.14#287

Open
hareshkh wants to merge 1 commit intotikv:masterfrom
hareshkh:hk/bump-pprof
Open

Bump pprof to 0.14#287
hareshkh wants to merge 1 commit intotikv:masterfrom
hareshkh:hk/bump-pprof

Conversation

@hareshkh
Copy link

@hareshkh hareshkh commented Mar 2, 2026

Summary by CodeRabbit

  • Chores

    • Updated core library dependencies to the latest stable versions, ensuring improved performance, reliability, and better compatibility with modern Rust ecosystem standards.
  • Refactor

    • Enhanced internal type safety and optimized memory efficiency by improving trait implementations across core data structures.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 2, 2026

Welcome @hareshkh! It looks like this is your first PR to tikv/pprof-rs 🎉

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 2, 2026

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01cff82 and 179bc56.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Cargo.toml
  • proto/perftools.profiles.rs
  • src/report.rs

📝 Walkthrough

Walkthrough

This PR upgrades prost protobuf dependencies from 0.12 to 0.14.1 and regenerates the associated Rust protobuf code. Several types now derive additional traits (Copy, Eq, Hash), clippy allow attributes are removed, and an unnecessary clone is eliminated in report.rs.

Changes

Cohort / File(s) Summary
Dependency Updates
Cargo.toml
Updated prost, prost-derive, and prost-build from version 0.12 to 0.14.1 across dependencies and build-dependencies.
Protobuf Code Generation
proto/perftools.profiles.rs
Added Copy, Eq, and Hash derives to ValueType, Label, Mapping, Line, and Function structs. Removed #[allow(clippy::derive_partial_eq_without_eq)] attributes from Profile, ValueType, Label, Mapping, Location, Line, and Function.
Code Update
src/report.rs
Removed .clone() call on time_value to leverage Copy trait semantics in Profile construction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a skip, through version land,
Dependencies climb to 0.14's hand,
Copy traits dance, no clones to spare,
Clippy's warnings fade in the air! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Bump pprof to 0.14' accurately reflects the main change: updating the prost dependency (pprof's core protobuf compiler) from version 0.12 to 0.14.1, along with corresponding updates to related dependencies and generated code.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant