Open
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
reviewed
Mar 2, 2022
| @@ -0,0 +1,72 @@ | |||
| # PD HTTP API V2 | |||
Contributor
There was a problem hiding this comment.
Can we introduce the store state refine? It's may influence downstream.
Member
Author
There was a problem hiding this comment.
Yes, I will add another section to introduce some refinement of the internal structure.
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
reviewed
Mar 8, 2022
|
|
||
| ### Behavior changes | ||
|
|
||
| In V2, we are planning to refactor the original store state. The previous implementation has some drawbacks: |
Contributor
There was a problem hiding this comment.
Would you like to add a store state change flow graph for v1,v2?
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
reviewed
Jul 28, 2022
| - Removing: just like the original `Offline`, but it's more clear | ||
| - Removed: the same as the original `Tombstone` | ||
|
|
||
| As for heartbeat status, we only add one normal status named `Alive` into the previous implementation. |
Contributor
There was a problem hiding this comment.
So Disconnect, and Down is gone?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Leung rleungx@gmail.com