chore(histogram): Simplify code by using std lib method#547
Merged
lucab merged 4 commits intotikv:masterfrom Apr 16, 2025
Merged
chore(histogram): Simplify code by using std lib method#547lucab merged 4 commits intotikv:masterfrom
lucab merged 4 commits intotikv:masterfrom
Conversation
|
Welcome @Cardosaum! It looks like this is your first PR to tikv/rust-prometheus 🎉 |
Leverage existing standard library method to simplify implementation. No changes to public API or MSRV. Signed-off-by: Matheus <cardosaum@pm.me>
Cardosaum
force-pushed
the
cardosaum/simplify-duration-to-seconds
branch
from
0b65dde to
7a8e057
Compare
lucab
requested changes
Apr 15, 2025
Member
|
@Cardosaum Thanks for the patch! |
Signed-off-by: Matheus <cardosaum@pm.me>
After removing the aforementioned method in a previous commit, this test became obsolete. Signed-off-by: Matheus <cardosaum@pm.me>
Contributor
Author
|
Thank you for the review @lucab! |
lucab
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverage existing standard library method to simplify implementation. No changes to public API or MSRV.