Replace all Into with From
#4792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iosmanthus Teng <[email protected]>
sticnarf
approved these changes
May 28, 2019
breezewish
approved these changes
May 28, 2019
There was a problem hiding this comment.
I'm curious why impl From for these foreign types is now possible. @kennytm
breezewish
added
status/LGT2
|
@breeswish magic of rust-lang/rust#56145 maybe |
breezewish
pushed a commit
to breezewish/tikv
that referenced
this pull request
Jun 12, 2019
Signed-off-by: Iosmanthus Teng <[email protected]>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Iosmanthus Teng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Iosmanthus Teng [email protected]
What have you changed? (mandatory)
Lots of code in
TiKVimplementInto<SomeType>for AnotherType but notFrom<AnotherType>for SomeType which will automatically implementInto<SomeType>and allow more explicitly construction.What are the type of changes? (mandatory)