Skip to content

Handle this-fallback for @arg Attr Node values within Element Nodes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gitKrystan merged 1 commit into from
May 10, 2023
Merged

Handle this-fallback for @arg Attr Node values within Element Nodes #13

gitKrystan merged 1 commit into from
May 10, 2023

Conversation

@gitKrystan
Copy link
Collaborator

@gitKrystan gitKrystan commented May 10, 2023

Supersedes #12

wycats
wycats approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@wycats wycats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gitKrystan
Copy link
Collaborator Author

gitKrystan commented May 10, 2023

Canary failure is unrelated and likely due to emberjs/ember.js#20449

@gitKrystan gitKrystan merged commit 6bb322b into main May 10, 2023
@gitKrystan gitKrystan deleted the handle-args branch May 10, 2023 17:47
@gitKrystan gitKrystan added the bug Something isn't working label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wycats wycats wycats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gitKrystan @wycats