Skip to content

fix: add Scope.Scope support to AtomRuntime.subscriptionRef and subscribable #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-smart merged 2 commits into from
Dec 10, 2025
Merged

fix: add Scope.Scope support to AtomRuntime.subscriptionRef and subscribable #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91aac3e
fix: add Scope.Scope support to AtomRuntime.subscriptionRef and subsc…
mikearnaldi Dec 3, 2025
6bb573d
wip
tim-smart Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-turkeys-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect-atom/atom": patch
---

add Scope support to Atom.subscriptionRef types
16 changes: 12 additions & 4 deletions docs/atom/Atom.ts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,18 +1024,26 @@ export interface AtomRuntime<R, ER = never> extends Atom<Result.Result<Runtime.R

readonly subscriptionRef: <A, E>(
create:
| Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>
| Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
| ((
get: Context
) => Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>)
) => Effect.Effect<
SubscriptionRef.SubscriptionRef<A>,
E,
Scope.Scope | R | AtomRegistry | Reactivity.Reactivity
>)
) => Writable<Result.Result<A, E>, A>

readonly subscribable: <A, E, E1 = never>(
create:
| Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>
| Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
| ((
get: Context
) => Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>)
) => Effect.Effect<
Subscribable.Subscribable<A, E, R>,
E1,
Scope.Scope | R | AtomRegistry | Reactivity.Reactivity
>)
) => Atom<Result.Result<A, E | E1>>
}
```
Expand Down
12 changes: 8 additions & 4 deletions packages/atom/src/Atom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,18 +622,22 @@ export interface AtomRuntime<R, ER = never> extends Atom<Result.Result<Runtime.R

readonly subscriptionRef: <A, E>(
create:
| Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>
| Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
| ((
get: Context
) => Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, R | AtomRegistry | Reactivity.Reactivity>)
) => Effect.Effect<SubscriptionRef.SubscriptionRef<A>, E, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>)
) => Writable<Result.Result<A, E>, A>

readonly subscribable: <A, E, E1 = never>(
create:
| Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>
| Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, Scope.Scope | R | AtomRegistry | Reactivity.Reactivity>
| ((
get: Context
) => Effect.Effect<Subscribable.Subscribable<A, E, R>, E1, R | AtomRegistry | Reactivity.Reactivity>)
) => Effect.Effect<
Subscribable.Subscribable<A, E, R>,
E1,
Scope.Scope | R | AtomRegistry | Reactivity.Reactivity
>)
) => Atom<Result.Result<A, E | E1>>
}

Expand Down
24 changes: 24 additions & 0 deletions packages/atom/test/Atom.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,30 @@ describe("Atom", () => {
unmount()
})

it("SubscriptionRef/runtime/scoped", async () => {
let finalized = false
const atom = counterRuntime.subscriptionRef(
Effect.gen(function*() {
yield* Effect.addFinalizer(() =>
Effect.sync(() => {
finalized = true
})
)
return yield* SubscriptionRef.make(0)
})
)
const r = Registry.make()
const unmount = r.mount(atom)
assert.deepStrictEqual(r.get(atom), Result.success(0, { waiting: true }))
r.set(atom, 1)
await new Promise((resolve) => resolve(null))
assert.deepStrictEqual(r.get(atom), Result.success(1, { waiting: true }))
assert.strictEqual(finalized, false)
unmount()
await new Promise((resolve) => resolve(null))
assert.strictEqual(finalized, true)
})

it("setLazy(true)", async () => {
const count = Atom.make(0).pipe(Atom.keepAlive)
let rebuilds = 0
Expand Down