feat!: removes Node.js 18 as it reached EOL #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes support for Node.js 18 and cleans up associated configurations and documentation to standardize on Node.js 20 and 22.
- Updated README.md to remove Node.js 18 references.
- Modified workflow files (.github/workflows/dockerimage.yml and buildx.yml) to remove Node.js 18 from the testing/build matrix and associated logic.
Reviewed Changes
Copilot reviewed 3 out of 19 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Removed Node.js 18 references and updated supported version notes. |
| .github/workflows/dockerimage.yml | Adjusted matrix configuration to only include Node.js 20 and 22. |
| .github/workflows/buildx.yml | Updated matrix configuration and removed codename handling for Node.js 18. |
Files not reviewed (16)
- 11/jdk/18/Dockerfile: Language not supported
- 11/jdk/18/alpine/Dockerfile: Language not supported
- 11/jre/18/Dockerfile: Language not supported
- 11/jre/18/alpine/Dockerfile: Language not supported
- 17/jdk/18/Dockerfile: Language not supported
- 17/jdk/18/alpine/Dockerfile: Language not supported
- 17/jre/18/Dockerfile: Language not supported
- 17/jre/18/alpine/Dockerfile: Language not supported
- 21/jdk/18/Dockerfile: Language not supported
- 21/jdk/18/alpine/Dockerfile: Language not supported
- 21/jre/18/Dockerfile: Language not supported
- 21/jre/18/alpine/Dockerfile: Language not supported
- 8/jdk/18/Dockerfile: Language not supported
- 8/jdk/18/alpine/Dockerfile: Language not supported
- 8/jre/18/Dockerfile: Language not supported
- 8/jre/18/alpine/Dockerfile: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for Node.js 18 across multiple workflows, Dockerfiles, and documentation, standardizing the project to support only Node.js 20 and 22. The changes also clean up associated Dockerfiles for Node.js 18, simplifying the codebase.
Workflow Updates:
.github/workflows/buildx.yml: Removed Node.js 18 from thematrix.node-versionconfiguration and its corresponding codename handling logic. [1] [2].github/workflows/dockerimage.yml: Removed Node.js 18 from thematrix.node-versionconfiguration.Dockerfile Cleanup:
Documentation Updates:
README.md: Updated to remove references to Node.js 18, reflecting the supported versions as Node.js 20 (Iron) and Node.js 22 (Jod).