Skip to content

Conversation

@mysza
Copy link
Contributor

@mysza mysza commented Dec 16, 2024

Summary

The formula parser clients use null, undefined, '' and false values to indicate "unset" field value (the last one is used by date type).

This change makes the parser less strict about the arguments:

  • in addition (+), if value is not set, we treat it as 0
  • other operators (subtraction, division, multiplication, power): if any of the operators is not set, we return Number.NaN, which is presented to the user as -, i.e. value not set, as we can't calculate it

Tests

  • updated tests
  • CI/CD ✅

@mysza mysza requested review from a team and AndreyGurskiy and removed request for a team and AndreyGurskiy December 17, 2024 08:15
@mysza mysza merged commit 5d0adc3 into main Dec 17, 2024
3 checks passed
@mysza mysza deleted the mike-m/CLK-578056/improve-no-date-handling branch December 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants