Skip to content

Conversation

@timebertt
Copy link
Owner

What this PR does / why we need it:

This PR renames the ClusterRing resource to ControllerRing. See the linked issue for the motivation.

⚠️ Please consult the updated documentation and examples for how to adapt to this breaking change.

  • The clusterring- string has been removed from the shard and drain labels.
  • There is no migration path available. You need to manually clean up installed resources (CRD, RBAC, etc.), remove old labels, and install the new resources.
  • The kind-related and namespace labels have been removed from the sharder metrics.

Which issue(s) this PR fixes:
Fixes #429

Special notes for your reviewer:

@timebertt timebertt added the breaking This PR contains a breaking change and should be listed accordingly in release notes. label Jan 24, 2025
@timebertt timebertt linked an issue Jan 24, 2025 that may be closed by this pull request
5 tasks
@timebertt timebertt enabled auto-merge (squash) January 24, 2025 22:43
@timebertt timebertt merged commit 9506c28 into main Jan 24, 2025
4 checks passed
@timebertt timebertt deleted the controllerring branch January 24, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This PR contains a breaking change and should be listed accordingly in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename ClusterRing to ControllerRing

2 participants