Add explicit skip-workload label for Websites
#609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from In progress
to Done
in kubernetes-controller-sharding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously,
webhosting-operatorhad logic to skip workload (Ingress.spec.ingressClassName=fake,Deployment.spec.replicas=0) specifically for e2e tests andWebsitesgenerated inexperiment.This PR inverts the dependency by adding a
skip-workloadlabel towebhosting-operator, making the logic independent from the use case.The
sample-generatoris extended with a--skip-workloadflag, which causes the new label to be set.Which issue(s) this PR fixes:
Fixes n/a
Special notes for your reviewer: