webhosting-operator: fix edge cases with missing status updates #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on the usual exponential backoff and accept the noisy logs.
timebertt
added
bug
timebertt
removed
the
no-release-note
github-project-automation
bot
moved this from In progress
to Done
in kubernetes-controller-sharding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR deflakes the webhosting-operator e2e tests, where a few websites end up in
Errorstate after adding or removing a shard.This happened because the website controller checks changes to the status before updating it. If it operates on a stale cache, it might incorrectly skip status updates. We keep this optimization to ensure reconciliations stay no-op (no API requests) if everything is up-to-date. To fix the edge cases, the website predicate triggers when observing the controller's status updates.
Which issue(s) this PR fixes:
Fixes flake 1, flake 2
Special notes for your reviewer: