Simplify experiment metrics run_id label
#646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from In progress
to Done
in kubernetes-controller-sharding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR simplifies how the
run_idlabel is added to the metrics ofexperiment.Instead of adding the
run_idlabel explicitly, theServiceMonitorcopies the pod UID to therun_idlabel.With this, all metrics from the
experimentpods get therun_idlabel, not only the metrics fromwebhosting-operator/pkg/experiment/tracker.Which issue(s) this PR fixes:
Fixes n/a
Special notes for your reviewer: