Closed
Conversation
|
Ox Agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation workflow for VHS-generated TUI/CLI recordings by standardizing outputs under docs/images/ and embedding the resulting GIFs into the docs pages.
Changes:
- Move VHS tape outputs from
docs/assets/todocs/images/and update the generator script accordingly. - Embed generated GIFs into
docs/usage.mdand most ofdocs/tui.md. - Add newly generated GIF artifacts under
docs/images/.
Reviewed changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/usage.md | Embeds the follow-mode GIF (images/start-task.gif). |
| docs/tui.md | Replaces screenshot placeholders with embedded GIFs for several TUI sections; command palette remains a placeholder comment. |
| docs/configuration.md | Updates screenshot placeholder path to docs/images/. |
| docs/tapes/*.tape | Updates Output paths to write GIFs into docs/images/. |
| docs/tapes/generate.sh | Updates tape generation to use docs/images/ and wraps Chromium invocation with --no-sandbox. |
| docs/tapes/README.md | Updates documentation to reference docs/images/ as the output directory. |
| docs/images/*.gif | Adds the generated GIF artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)" | ||
| TMP_DIR="$(mktemp -d)" |
Comment on lines
+27
to
+32
| if command -v chromium >/dev/null 2>&1; then | ||
| CHROMIUM_BIN="$(command -v chromium)" | ||
| elif command -v chromium-browser >/dev/null 2>&1; then | ||
| CHROMIUM_BIN="$(command -v chromium-browser)" | ||
| else | ||
| echo "Error: chromium not found on PATH" >&2 |
| Press `ctrl+p` from any view to open the command palette -- a fuzzy-searchable list of all available actions. | ||
|
|
||
| <!-- screenshot: docs/assets/command-palette.gif --> | ||
| <!-- screenshot: docs/images/command-palette.gif --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing