Add postgres_exporter to docker image#481
Open
saolof wants to merge 1 commit intotimescale:masterfrom
Open
Conversation
The missing exporter in the trio. Not mandatory but still quite useful to have when dealing with a lagging replica for example. Ultimately whether it should be part of the image or not is an engineering tradeoff. The pgbackrest exporter looks directly at the pgbackrest volume and benefits from being in the same image. The other two could be in a separate image but are convenient to include in order to have the same image for everything. Signed-off-by: saolof <olof.salberger@gmail.com>
|
|
graveland
approved these changes
Jul 23, 2024
Collaborator
graveland
left a comment
graveland
left a comment
There was a problem hiding this comment.
Thanks!
I'm on the fence about including it, but maybe the decision to not make this image even larger gets to be pushed off a bit more :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing exporter in the trio. Not mandatory, but still quite useful to have when dealing with a lagging replica for example.
Ultimately whether it should be part of the image or not is an engineering tradeoff, feel free to reject this for any reason. The pgbackrest exporter looks directly at the pgbackrest volume and benefits from being in the same image. The other two could be in a separate image but are convenient to include in order to use the same image for everything.