Open
Conversation
mock time advances immediately (no jobs blocking), triggering this race on macOS debug builds where scheduling is less deterministic. Fix by accepting BGWH_STOPPED alongside BGWH_STARTED in the scheduler mock test functions, matching the production bgw_launcher.c behavior. ``` Co-Authored-By: Claude <noreply@anthropic.com>
|
@natalya-aksman, @antekresic: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR was automatically generated by Claude Code to fix a failing nightly CI test.
Test Fixed
cagg_bgwWhat Changed
mock time advances immediately (no jobs blocking), triggering this race on macOS debug builds where scheduling is less deterministic. Fix by accepting BGWH_STOPPED alongside BGWH_STARTED in the scheduler mock test functions, matching the production bgw_launcher.c behavior. ```
Co-Authored-By: Claude noreply@anthropic.com
Original Failure
Testing
Please review the fix and ensure it is appropriate before merging.
The CI will run the full test suite to verify the fix.
🤖 Generated with Claude Code