fix: aria described by sometimes returning stale 'undefined' value#86
Open
PavlovicWorkCo wants to merge 1 commit intotimhettler:mainfrom
Open
fix: aria described by sometimes returning stale 'undefined' value#86PavlovicWorkCo wants to merge 1 commit intotimhettler:mainfrom
PavlovicWorkCo wants to merge 1 commit intotimhettler:mainfrom
Conversation
|
@PavlovicWorkCo is attempting to deploy a commit to the Tim Hettler's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in which the
Card.Targetis returningundefinedforaria-describedby, causing screen readers not to read the additional description.I'm not sure in exactly what cases this is happening. You can confirm in on our project by just removing the temporary patch I added that this is happening for a(some) certain component(s).
The issue:
The fix:
Move
React.useId()up toCard.Rootso the ID is part of the context from the very first render — no mutation needed.