Skip to content

Work around global Object.prototype pollution #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timostamm merged 2 commits into from
Jun 18, 2025
+4 −2
Merged

Work around global Object.prototype pollution #725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
451a969
Work around global `Object.prototype` pollution
jcready Jun 18, 2025
2db9c80
Cast to compatible types
timostamm Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/runtime/src/message-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ import type {UnknownMessage} from "./unknown-types";
import {binaryWriteOptions} from "./binary-writer";
import {binaryReadOptions} from "./binary-reader";

const baseDescriptors = Object.getOwnPropertyDescriptors(Object.getPrototypeOf({}));
const baseDescriptors = Object.getOwnPropertyDescriptors(Object.getPrototypeOf({})) as Record<typeof MESSAGE_TYPE, unknown>;
const messageTypeDescriptor = baseDescriptors[MESSAGE_TYPE] = {} as {value?: unknown};

/**
* This standard message type provides reflection-based
Expand Down Expand Up @@ -69,7 +70,8 @@ export class MessageType<T extends object> implements IMessageType<T> {
this.typeName = name;
this.fields = fields.map(normalizeFieldInfo);
this.options = options ?? {};
this.messagePrototype = Object.create(null, { ...baseDescriptors, [MESSAGE_TYPE]: { value: this } });
messageTypeDescriptor.value = this;
this.messagePrototype = Object.create(null, baseDescriptors);
this.refTypeCheck = new ReflectionTypeCheck(this);
this.refJsonReader = new ReflectionJsonReader(this);
this.refJsonWriter = new ReflectionJsonWriter(this);
Expand Down
Loading