Skip to content

⚡ Bolt: Parallelize machine and issue fetching in Issues page #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: Parallelize machine and issue fetching in Issues page #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 28 additions & 26 deletions src/app/(app)/issues/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@ export default async function IssuesPage({
const params = await searchParams;
const { status, severity, priority, machine } = params;

// Fetch machines for filter dropdown
const allMachines = await db.query.machines.findMany({
orderBy: (machines, { asc }) => [asc(machines.name)],
columns: { initials: true, name: true },
});

// Safe type casting for filters
// Default to Open issues (new + in_progress) if no status is specified
// If status is 'resolved', show resolved issues
Expand All @@ -69,28 +63,36 @@ export default async function IssuesPage({
? (priority as "low" | "medium" | "high" | "critical")
: undefined;

// Fetch Issues based on filters
const issuesList = await db.query.issues.findMany({
where: and(
inArray(
issues.status,
statusFilter as ("new" | "in_progress" | "resolved")[]
// Fetch machines and issues in parallel
const [allMachines, issuesList] = await Promise.all([
// Fetch machines for filter dropdown
db.query.machines.findMany({
orderBy: (machines, { asc }) => [asc(machines.name)],
columns: { initials: true, name: true },
}),
// Fetch Issues based on filters
db.query.issues.findMany({
where: and(
inArray(
issues.status,
statusFilter as ("new" | "in_progress" | "resolved")[]
),
severityFilter ? eq(issues.severity, severityFilter) : undefined,
priorityFilter ? eq(issues.priority, priorityFilter) : undefined,
machine ? eq(issues.machineInitials, machine) : undefined
),
severityFilter ? eq(issues.severity, severityFilter) : undefined,
priorityFilter ? eq(issues.priority, priorityFilter) : undefined,
machine ? eq(issues.machineInitials, machine) : undefined
),
orderBy: desc(issues.createdAt),
with: {
machine: {
columns: { name: true },
},
reportedByUser: {
columns: { name: true },
orderBy: desc(issues.createdAt),
with: {
machine: {
columns: { name: true },
},
reportedByUser: {
columns: { name: true },
},
},
},
limit: 100, // Reasonable limit for now
});
limit: 100, // Reasonable limit for now
}),
]);

return (
<div className="container mx-auto max-w-5xl py-8 px-4 sm:px-6">
Expand Down