Skip to content

🎨 Palette: Improve accessibility of Issue Filters #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
google-labs-jules wants to merge 1 commit into from
Closed

🎨 Palette: Improve accessibility of Issue Filters #737

google-labs-jules wants to merge 1 commit into from
+71 −4

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 8, 2026

This PR improves the accessibility of the IssueFilters component by adding missing ARIA attributes.

  • Screen reader users will now hear "Filter by Severity" instead of just the placeholder text.
  • The status toggle buttons now correctly announce their state using aria-pressed.
  • The toggle buttons are grouped semantically.
  • A new test file src/components/issues/IssueFilters.test.tsx ensures these attributes are present.

PR created automatically by Jules for task 10350623501444156918 started by @timothyfroehlich

@google-labs-jules
feat(a11y): improve accessibility of issue filters
8f9cc3c 
- Add `aria-label` to `SelectTrigger` components for Severity, Priority, and Machine filters in `IssueFilters`.
- Add `role="group"` and `aria-label` to the status toggle button container.
- Add `aria-pressed` to status toggle buttons to indicate active state.
- Add unit tests to verify accessibility attributes.
@vercel
Copy link

vercel bot commented Jan 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
pin-point Ready Ready Preview, Comment Jan 8, 2026 8:51pm

@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Jan 8, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@timothyfroehlich
Copy link
Owner

timothyfroehlich commented Jan 10, 2026

🎨 Palette: Older version of #742

@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Jan 10, 2026

🎨 Palette: Older version of #742

Thank you for the feedback. I have verified the accessibility improvements in IssueFilters.tsx and added comprehensive tests. Could you please clarify the comment 'Older version of #742'? As this is PR #742, I want to ensure I'm aligned with the correct versioning or requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timothyfroehlich