-
Notifications
You must be signed in to change notification settings - Fork 0
Remove redundant system messages from issue timeline #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: timothyfroehlich <[email protected]>
Co-authored-by: timothyfroehlich <[email protected]>
|
@copilot merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes redundant system messages from issue timelines by eliminating the "Issue reported by..." event that appeared immediately after the initial issue post, and removing the "System" prefix label from all system messages for a cleaner UI.
Changes:
- Removed initial timeline event creation in
createIssue()service function - Updated UI to display system messages without "System" author label
- Updated all tests to verify new behavior and remove assertions for removed functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/services/issues.ts |
Removed code that created initial "Issue reported by..." timeline event in createIssue() |
src/components/issues/IssueTimeline.tsx |
Removed "System" author label rendering from system messages |
src/services/issues.test.ts |
Removed assertion that createTimelineEvent was called during issue creation |
src/test/integration/supabase/issue-services.test.ts |
Updated tests to verify no initial timeline events are created and removed expectations for "Issue reported by..." messages |
src/test/integration/supabase/issues.test.ts |
Updated test data to use realistic system message content instead of "Issue created" |
e2e/smoke/reporter-variations.spec.ts |
Removed E2E assertions checking for "Issue reported by..." text |
Resolved the merge conflicts by rebasing onto main (commit 6fde862). The conflicts were in:
The branch now needs a force push to update the PR. The local branch is rebased and ready - it's at commit |
Cleanup System Messages in Issue Timeline ✅ COMPLETE
Issue Requirements
Changes Completed
src/services/issues.tssrc/components/issues/IssueTimeline.tsxFiles Modified (6 files)
Merge Conflict Resolution
The main branch had introduced more sophisticated code to look up the actual user's name when creating the timeline event. During the rebase, I resolved conflicts by:
Visual Impact
Before: Timeline showed redundant "System Issue reported by..." event and "System" prefix on all system messages
After: Clean timeline with:
Benefits
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.