Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 12, 2026

Machine owners are now visible to all authenticated users, while edit access remains admin-only.

Changes

UpdateMachineForm component (src/app/(app)/m/[initials]/update-machine-form.tsx)

  • Admins: Editable OwnerSelect dropdown (unchanged)
  • Non-admins: Read-only display showing owner name, invited status badge, or "No owner assigned"
  • Extended interface to accept owner and invitedOwner data from existing query

E2E test (e2e/smoke/machines-crud.spec.ts)

  • Added test verifying owner display visibility for non-admin users
{isAdmin ? (
  <OwnerSelect users={allUsers} defaultValue={ownerId} />
) : (
  <div data-testid="owner-display">
    <Label>Machine Owner</Label>
    <div className="rounded-md border px-3 py-2">
      {owner?.name ?? invitedOwner?.name ?? "No owner assigned"}
    </div>
  </div>
)}

No backend changes required—machine detail page already fetches owner data.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chrome-for-testing-public/143.0.7499.4/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/.npm/_npx/e41f203b7505f1fb/node_modules/playwright-core/lib/server/registry/oopDownloadBrowserMain.js (http block)
  • https://storage.googleapis.com/chrome-for-testing-public/143.0.7499.4/linux64/chrome-linux64.zip
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/.npm/_npx/e41f203b7505f1fb/node_modules/playwright-core/lib/server/registry/oopDownloadBrowserMain.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Machine owners should be shown to all logged in users.</issue_title>
<issue_description>Only admins can change them, but the machine info page should show the owner.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link

vercel bot commented Jan 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
pin-point Ready Ready Preview, Comment Jan 12, 2026 3:54am

- Add owner display field for non-admin users in UpdateMachineForm
- Keep editable owner select for admin users only
- Show owner name with invited status indicator when applicable
- Display "No owner assigned" message when no owner is set

Co-authored-by: timothyfroehlich <[email protected]>
Copilot AI and others added 3 commits January 12, 2026 03:50
- Add test to verify machine owner is visible to non-admin users
- Verify owner name and help text are displayed correctly

Co-authored-by: timothyfroehlich <[email protected]>
- Ensure (Invited) badge only shows when owner is truly in invited state
- Prevents showing badge when invited owner has accepted invitation

Co-authored-by: timothyfroehlich <[email protected]>
Copilot AI changed the title [WIP] Show machine owners to all logged in users Display machine owner to all logged-in users Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Machine owners should be shown to all logged in users.

2 participants