🛡️ Sentinel: [CRITICAL] Fix Host Header Injection in Auth Callback #781
Conversation
Refactored `resolveRedirectPath` in `src/app/auth/callback/route.ts` to strictly validate redirect URLs against the configured `NEXT_PUBLIC_SITE_URL` via `getSiteUrl()`. This prevents Host Header Injection attacks where a malicious `X-Forwarded-Host` header could redirect users to an attacker-controlled domain. - Modified `resolveRedirectPath` to ignore `origin` and `forwardedHost` inputs and use `getSiteUrl()` instead. - Updated `GET` handler to use `getSiteUrl()` for constructing the base redirect URL. - Updated tests in `src/app/auth/callback/route.test.ts` to reflect the new signature and verify security against spoofed hosts. - Removed `package-lock.json` as the project uses pnpm.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This PR addresses a Host Header Injection vulnerability in the authentication callback route.
Previously, the
resolveRedirectPathfunction trustedX-Forwarded-Hostororiginheaders to validate and construct redirect URLs. This could allow an attacker to spoof the host header and redirect authenticated users to a malicious site.The fix involves:
resolveRedirectPathto strictly validate the redirect target against the trustedNEXT_PUBLIC_SITE_URL(retrieved viagetSiteUrl()).GEThandler to usegetSiteUrl()when constructing the absolute redirect URL.NEXT_PUBLIC_SITE_URL.This ensures that redirects always go to the configured application domain.
Additionally,
package-lock.jsonwas removed as the project usespnpm.PR created automatically by Jules for task 17823098564230585764 started by @timothyfroehlich