Refactor admin actions to prevent error information leakage #784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel: [MEDIUM] Fix information leakage in admin actions
Vulnerability:
Admin actions (
updateUserRole,inviteUser,resendInvite) were throwing raw errors directly to the client. This could expose internal details (e.g., stack traces, database errors, email service errors) if not properly handled by the framework or if debug mode is enabled.Impact:
Potential exposure of sensitive system information or confusing error messages to end users.
Fix:
Refactored these actions to use the
Resultpattern (ok,err) consistent with other parts of the application.try-catchblocks.log.error.InviteUserDialog,UserRoleSelect, andResendInviteButtonto handle theResulttype and display safe error messages.Verification:
pnpm typecheck,pnpm lint, andpnpm build.PR created automatically by Jules for task 11930672150919906896 started by @timothyfroehlich