-
Notifications
You must be signed in to change notification settings - Fork 0
Add health check and update docs for automated Supabase startup #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health check and update docs for automated Supabase startup #811
Conversation
Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8986a4d
into
chore/run-dev-starts-supabase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the automated Supabase startup by adding a health check that waits for services to be fully initialized before allowing the dev server to start. This addresses a race condition identified in PR #810 where Next.js could attempt database connections before Supabase was ready.
Changes:
- Added health check polling in
ensure-supabase.shwith 60-second timeout to verify Auth service readiness - Updated developer documentation to reflect that
pnpm run devnow fully handles Supabase startup without requiring a separate terminal
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/ensure-supabase.sh |
Added health check loop that polls Auth service endpoint after Supabase starts, with retry logic and timeout handling |
docs/DEVELOPMENT.md |
Simplified quickstart instructions to show single command for dev server startup |
README.md |
Updated local setup to reflect automated Supabase handling in dev command |
* chore: ensure supabase is running before dev server starts * Update scripts/ensure-supabase.sh Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add health check and update docs for automated Supabase startup (#811) * Initial plan * feat: add health check and update docs for automated Supabase startup Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Addresses review feedback from PR #810: the dev server could start before Supabase services were fully initialized, causing connection failures.
Changes
Health check in
scripts/ensure-supabase.sh: After starting Supabase, polls Auth service health endpoint (60s timeout) before returning. Prevents race conditions where Next.js attempts database connections before Supabase is ready.Documentation updates: Simplified
README.mdanddocs/DEVELOPMENT.mdto reflect thatpnpm run devnow handles Supabase startup automatically—no separate terminal needed.Implementation
Follows the same health check pattern used in
scripts/supabase-init-for-tests.sh:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.