Skip to content

Conversation

@twsl
Copy link
Contributor

@twsl twsl commented Oct 16, 2024

In order to understand the current issues with the passed data, I tried to add type hints to the library

@twsl twsl marked this pull request as ready for review October 16, 2024 12:41
Copy link
Owner

@timvink timvink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Some nice house keeping :)

Couple of small remarks.

And yes I should have run a code formatter like ruff on top of this plugin, and set it up as a pre-commit hook.

@twsl
Copy link
Contributor Author

twsl commented Oct 16, 2024

@timvink let's handle ruff in a separate PR, everything else should be good to go

@twsl twsl requested a review from timvink October 16, 2024 21:14
@timvink timvink merged commit 0b3cf36 into timvink:master Oct 17, 2024
12 checks passed
@twsl twsl deleted the feature/typehints branch October 17, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants