-
Notifications
You must be signed in to change notification settings - Fork 677
🚧 WIP - Fix TinaCMS issue 6300 #6301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added test coverage for video link timestamp preservation to ensure query parameters (t=, start=) and hash fragments are correctly maintained in sanitized URLs. Tests cover: - YouTube standard format (/watch?v=...&t=...) - YouTube short format (youtu.be/...?t=...) - YouTube start parameter (&start=...) - Vimeo hash timestamps (#t=...s) Fixes #6300
|
Playwright E2E Test ResultsDetails
Skipped testschromium › retain-input-value-from-localstorage.spec.ts › Local storage retain edit test |
|
@kulesy For embed link it is |
Extended test coverage to include YouTube embed URLs (used in iframes) which use the /embed/ path format and different timestamp parameters: - YouTube embed with start parameter (?start=60) - YouTube embed with multiple parameters (?start=60&autoplay=1) These URLs are commonly used when embedding videos in iframes and need to preserve their query parameters to maintain timestamp functionality. Related to #6300
Created comprehensive round-trip test (markdown → Plate → markdown) to verify that video URLs with timestamp parameters are correctly preserved throughout the entire editing flow. Test cases cover: - YouTube watch URLs with &t= parameter - YouTube short URLs (youtu.be) with ?t= parameter - YouTube embed URLs with ?start= parameter (for iframes) - Vimeo URLs with #t= hash parameter This test verifies that when a user: 1. Opens markdown with video links in the TinaCMS editor 2. Edits content in the rich text editor 3. Saves back to markdown The video timestamp parameters are preserved correctly, ensuring videos start at the specified time when links are clicked. Fixes #6300
Added test coverage for video link timestamp preservation to ensure query parameters (t=, start=) and hash fragments are correctly maintained in sanitized URLs. Tests cover:
Fixes #6300