Open
Conversation
milesdai
approved these changes
Jan 13, 2026
.github/workflows/release.yml
Outdated
Comment on lines
32
to
36
| if [[ "$GITHUB_REF" == refs/tags/* ]]; then | ||
| VERSION=${GITHUB_REF#refs/tags/} | ||
| else | ||
| VERSION="dev-${GITHUB_SHA::8}" | ||
| fi |
Contributor
There was a problem hiding this comment.
Not blocking on this PR, but you could consider using git describe to accomplish something similar without the conditional check.
VERSION=$(git describe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Run the release workflow on pull requests to main and use a dev version string, without publishing. Fixes missing builds on PRs and prevents accidental releases.
Written for commit 8107f56. Summary will update on new commits.