Skip to content

Comments

fix: build on pull requests to main#96

Open
jdrean wants to merge 2 commits intomainfrom
fix/releases
Open

fix: build on pull requests to main#96
jdrean wants to merge 2 commits intomainfrom
fix/releases

Conversation

@jdrean
Copy link
Member

@jdrean jdrean commented Jan 13, 2026

Summary by cubic

Run the release workflow on pull requests to main and use a dev version string, without publishing. Fixes missing builds on PRs and prevents accidental releases.

  • Bug Fixes
    • Trigger workflow on pull_request to main.
    • Set VERSION to dev-${GITHUB_SHA::8} when not building a tag.
    • Skip GH Pages deploy and GitHub Release on pull_request.

Written for commit 8107f56. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@jdrean jdrean requested a review from milesdai January 13, 2026 17:34
Copy link
Contributor

@milesdai milesdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 32 to 36
if [[ "$GITHUB_REF" == refs/tags/* ]]; then
VERSION=${GITHUB_REF#refs/tags/}
else
VERSION="dev-${GITHUB_SHA::8}"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking on this PR, but you could consider using git describe to accomplish something similar without the conditional check.

VERSION=$(git describe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants