Skip to content

Conversation

@jovanmaric
Copy link
Contributor

@jovanmaric jovanmaric commented Mar 17, 2025

feat(lock): add multiple gem platforms
feat(bundler): add require in tests and include base64 default gem
feat(ci): remove ruby EOL versions
feat(webmock): update to 3.x.x
feat(webmock): update to 2.x.x and update tests
feat(gems): update
feat(httpclient): change pin and update
feat(rake): relax pin and update
feat(minitest): relax pin and update

@rkoopmans rkoopmans requested review from Copilot and rkoopmans March 17, 2025 17:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR includes multiple dependency and test suite updates to improve compatibility and maintainability of the project. Key changes include updated require statements in tests, dependency version adjustments in the gemspec and Gemfile, and extensive updates to stub requests in tests to use basic authentication via separate parameters instead of inline credentials.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/helper.rb Updated require ordering and changed MiniTest::Spec to Minitest::Spec
tinify.gemspec Updated httpclient dependency version constraints
test/tinify_client_test.rb Updated stub_request calls to separate basic_auth from URL credentials
Gemfile Removed explicit version pins for several dependencies and added base64
.github/workflows/ci-cd.yaml Revised Ruby version matrix in CI
test/tinify_test.rb Adjusted stub_request calls to use basic_auth parameters
test/tinify_source_test.rb Updated stub_request calls for improved authentication handling
Comments suppressed due to low confidence (2)

Gemfile:6

  • The Base64 module is part of Ruby’s standard library, so explicitly adding it as a dependency may be unnecessary and might introduce versioning conflicts; consider removing it if not required.
gem 'base64'

test/helper.rb:30

  • [nitpick] The change from 'MiniTest::Spec' to 'Minitest::Spec' may cause inconsistencies if other parts of the codebase still refer to the original name; please ensure that all references are updated consistently.
-class MiniTest::Spec

@jovanmaric jovanmaric force-pushed the fix/3.2+ branch 3 times, most recently from 569882f to 549dcd0 Compare March 17, 2025 19:16
@rkoopmans rkoopmans merged commit 5dab127 into tinify:master Mar 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants