Use Linux architecture names in output artifact filenames:#49
Merged
mergify[bot] merged 1 commit intotinkerbell:mainfrom Mar 9, 2026
Merged
Use Linux architecture names in output artifact filenames:#49mergify[bot] merged 1 commit intotinkerbell:mainfrom
mergify[bot] merged 1 commit intotinkerbell:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates CaptainOS artifact naming to use Linux-style architecture strings (x86_64, aarch64) in user-facing output filenames (to better align with Tinkerbell/iPXE expectations), and adjusts build/release paths accordingly.
Changes:
- Add
output_archtoArchInfoand use it for output artifact filenames across build, checksums, QEMU, ISO, and OCI release packaging. - Rename initramfs artifact references to remove the
.cpio.zstsuffix and update ISO GRUB/initramfs staging accordingly. - Update CI workflow and docs/README examples to reflect the new naming.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/design-decisions/oci-tooling-buildah-skopeo.md | Update example artifact filenames to x86_64 naming. |
| captain/util.py | Introduce ArchInfo.output_arch and map amd64→x86_64, arm64→aarch64. |
| captain/tools.py | Comment wording updated about why UPX isn’t used. |
| captain/qemu.py | QEMU boot now looks for vmlinuz/initramfs artifacts using output_arch. |
| captain/oci/_build.py | OCI artifact collection/checksums now use output_arch in filenames. |
| captain/iso.py | ISO contents and GRUB config now use initramfs (no .cpio.zst) and ISO output filename uses output_arch. |
| captain/config.py | Update initramfs output docstring (less specific about filename). |
| captain/cli/_stages.py | ISO idempotency path updated to output_arch. |
| captain/cli/_commands.py | Checksums default file set and error text updated to output_arch and new initramfs name. |
| captain/artifacts.py | Collected kernel/initramfs/ISO artifact names now use output_arch; initramfs suffix removed. |
| README.md | Update initramfs naming examples and release artifact naming to x86_64/aarch64. |
| .github/workflows/ci.yml | CI updated to copy/upload ISO/initramfs artifacts using output_arch mapping in matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tinkerbell iPXE scripts are built around architecture naming in a specific way. x86_64 and aarch64. This makes CaptainOS backward compatible. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
refactor-cli-oci
branch
from
01b1a54 to
c9d73bc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
97 tasks
Contributor
Merge Queue Status
This pull request spent 3 minutes 7 seconds in the queue, including 2 minutes 56 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
Member
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 12 minutes 48 seconds in the queue, including 12 minutes 25 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tinkerbell iPXE scripts are built around architecture naming in a specific way. x86_64 and aarch64. This makes CaptainOS backward compatible.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: