runtime (scheduler): generalize scheduler beyond timers #1006
Conversation
There was a problem hiding this comment.
Some stylistic comments, although I'm still not understanding what is going on here (see #1010 (comment)).
| } | ||
| const pollInterval = 256 | ||
|
|
||
| // Run the scheduler until all tasks have finished. |
There was a problem hiding this comment.
I do not believe this sentence is true anymore with this PR: the scheduler runs until the main task has finished.
|
|
||
| // poll checks for any events that are ready and pushes them onto the runqueue. | ||
| // It returns true if any tasks were ready. | ||
| func poll() bool { |
There was a problem hiding this comment.
The name of this function is rather broad. Perhaps something like pollForEvents or checkForNewTasks? Or fillRunqueue?
| } | ||
|
|
||
| // wait sleeps until any tasks are awoken by external events. | ||
| func wait() { |
There was a problem hiding this comment.
Same for this function. I think something like waitForEvents would be clearer.
(I'm assuming this will wait for the next interrupt soon, with wfe?)
There was a problem hiding this comment.
Yes, #1040 adds an implementation for atsamd21 which directly uses wfe.
|
Closing in favor of #1142 |
2 participants
No description provided.