Go 1.14 support #1035
Merged
Go 1.14 support #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
Author
Member
|
@aykevl this branch is now ready for conflict resolution, please. |
This makes the result consistent across Go versions, by running a regex on the CGo output that wraps all single-line functions in a consistent way. Originally written by Elliott Sales de Andrade and modified by Ayke van Laethem.
It doesn't seem to be used. This commit is somewhat related to this commit: golang/go@6dd70fc Most of the things don't port over nicely.
See commit: golang/go@54e6ba6 Warning: this will drop support for Go 1.13 for WebAssembly targets! I have modified the integration tests to specifically blacklist Go 1.13 instead of whitelisting any other version, to avoid accidentally not testing WebAssembly.
Member
Author
|
Rebased and fixed conflicts. |
Member
|
Tested with this branch and Go 1.14.2 with some of my demos on AVR, SAMD21, SAMD51, and Hi5 boards, and all worked perfectly. I think this is ready for merge. |
Member
Closed
Contributor
|
Great news folks! Now when |
Member
Author
|
Yes that will happen very soon now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #901. I have modified the PR of @QuLogic to include the bits needed to get all tests to run on Go 1.14 and extended it a bit to switch to Go 1.14 entirely.
Note that this PR drops support for WebAssembly on Go 1.13 (at least when you import the syscall/js package) but I think working around that would be difficult. It should definitely be possible to create a workaround (for example, by exporting a function that when called returns the Go minor version) but I'd like to avoid such hacks if possible. Therefore I would propose keeping it as-is for now and only adding a workaround if there is enough demand (which I don't expect).
This will probably conflict with #1014 but the conflicts should be easy to resolve.