src/os: export correct values for os.DevNull for each OS #2681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZauberNerd
force-pushed
the
devnull
branch
3 times, most recently
from
bbea6ff to
8ca273a
Compare
This commit introduces `os.DevNull` exports for all supported OS targets.
Contributor
|
If this will be supported everywhere, that will be helpful for #2515. |
Member
|
Thank you @ZauberNerd 🔥 merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
os.DevNullexports for all supported OStargets.
I had to introduce a new file
file_wasi.goin order to export adifferent value for
file_windows.go(NUL) and keep/dev/nullforall other targets.
I'll create this PR as draft, because I have a few open questions:
I'm not sure, if this works correctly with the build tags or if thefile_anyos.gotakes precedence over thefile_windows.go.Other options that I see:
file_other.go,file_unix.goandfile_windows.go, ignoring WASI1.1 create a separate
file_wasi.goto be able to exportDevNullthere too (seems overkill?)file_anyos.goandfile_other.go, ignoring Windows