main_test.go: fork testdata/testing.go for go 1.18 #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkegel-fastly
force-pushed
the
dkegel-fork-testdata-testing-go1.18
branch
2 times, most recently
from
acf7756 to
1c815dc
Compare
Member
|
@dkegel-fastly can you please rebase against |
dkegel-fastly
force-pushed
the
dkegel-fork-testdata-testing-go1.18
branch
from
1c815dc to
71a0d01
Compare
deadprogram
approved these changes
Apr 6, 2022
Member
|
Thank you @dkegel-fastly now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoisted out of #2725
Makes tests happier under go 1.18
Shame about the duplication...