os/StartProcess #4377

leongross · 2024-08-02T11:11:15Z

This is a rework of #4323 (based on that branch) to move the Execve and Fork wrappers to the os package to circumvent the goroot overrides.

aykevl

Quick initial (incomplete) review

src/os/osexec.go

src/os/exec_other.go

src/os/exec_linux.go

leongross · 2024-08-05T15:24:09Z

main_test.go:394: /home/runner/work/tinygo/tinygo/src/os/osexec.go:14:23: undefined: syscall.Syscall

ci fails with undefined syscall.Syscall. I thought since it is just a package the compiler would pick that up when building it. @aykevl

EDIT: it looks like this is only happening on architectures that the createRawSyscall function does not target, which makes sense, namely EmulatedCortexM3 : cortex-m-qemu and EmulatedRISCV : riscv-qemu. Anyways, this should not happen.
https://github.com/tinygo-org/tinygo/blob/dev/main_test.go#L522

Anyhow the smoke tests fail without any further information of what went wrong on linux, windows and mac. the smoke test cannot be removed, it is not clear though why it wasn't build in the first place

rm: cannot remove 'smoke.test': No such file or directory

leongross · 2024-08-08T11:00:40Z

Not sure if something like #4398 would fix this? @aykevl

aykevl · 2024-08-08T12:21:49Z

Not sure if something like #4398 would fix this? @aykevl

No, that's the wrong approach. If syscall.Syscall fails on baremetal systems, then the solution is not to implement these syscalls (because they're baremetal, so there is no OS to call into), but rather to figure out why these calls are made.

src/os/osexec.go

src/os/tempfile.go

leongross · 2024-08-22T12:39:45Z

@deadprogram @dgryski @aykevl build and tests finally succeed, would appreciate another review.

leongross · 2024-08-29T16:07:16Z

@aykevl @deadprogram @dgryski would someone mind reviewing?

src/os/osexec.go

Signed-off-by: leongross <[email protected]>

remove old comments, replace explicit syscall numbers with named variants, undo tempfile seed generation, remove old // +build tags, improve StartProcess documentation, remove custom syscall number definitions. Signed-off-by: leongross <[email protected]>

aarch64 has no support for the fork ssycall. for now exclude it. Signed-off-by: leongross <[email protected]>

Signed-off-by: leongross <[email protected]>

leongross · 2024-11-02T00:58:37Z

@aykevl

src/os/exec_linux.go

aykevl

Just a few small things, otherwise this PR seems ready for merging.

aykevl · 2024-11-04T15:52:40Z

src/os/exec_linux.go

+		return 0, errors.New("exec: no argv")
+	}
+
+	if len(argv) == 0 {


Nitpick: with this check, the previous check is unnecessary. len(argv) of a nil slice is always 0.

I think this was left behind and got merged 🙂

Yeah, it wasn't a blocker for me. It's not a bug, just code that could have been cleaner.

aykevl · 2024-11-04T15:55:31Z

src/os/os.test

This file needs to be removed.

aykevl · 2024-11-04T15:58:57Z

src/os/osexec_aarch64.go

@@ -0,0 +1,18 @@
+//go:build linux && !baremetal && !darwin && !tinygo.wasm && aarch64


aarch64 is not a valid Go build tag.

I think this file can be removed entirely now, since these things are implemented in osexec.go?

aykevl · 2024-11-04T16:16:50Z

src/os/osexec.go

+//go:build linux && !baremetal && !tinygo.wasm
+
+// arm64 does not have a fork syscall, so ignore it for now
+// TODO: add support for arm64 with clone or use musl implementation


This comment needs to be updated or removed since it is outdated.

aykevl · 2024-11-07T08:45:58Z

Thank you! I have merged the PR.

leongross · 2024-11-07T13:21:50Z

Thanks for merging and the thorough review @aykevl!

leongross force-pushed the os/StartProcessOs branch 6 times, most recently from 43fcf8f to 8cce6c2 Compare August 2, 2024 12:06

aykevl reviewed Aug 2, 2024

View reviewed changes

src/os/osexec.go Outdated Show resolved Hide resolved

src/os/osexec.go Outdated Show resolved Hide resolved

src/os/exec_other.go Show resolved Hide resolved

src/os/exec_linux.go Outdated Show resolved Hide resolved

leongross force-pushed the os/StartProcessOs branch from fffffce to 0844543 Compare August 5, 2024 08:45

leongross requested a review from aykevl August 5, 2024 09:21

leongross marked this pull request as ready for review August 6, 2024 12:39

aykevl reviewed Aug 8, 2024

View reviewed changes

src/os/osexec.go Outdated Show resolved Hide resolved

leongross force-pushed the os/StartProcessOs branch from 4189be1 to a67e057 Compare August 8, 2024 12:56

leongross requested a review from aykevl August 8, 2024 14:57

leongross force-pushed the os/StartProcessOs branch 3 times, most recently from e369ae7 to bf011fe Compare August 9, 2024 10:19

leongross force-pushed the os/StartProcessOs branch 5 times, most recently from bbf1159 to ffa5a87 Compare August 22, 2024 10:41

leongross commented Aug 22, 2024

View reviewed changes

src/os/tempfile.go Outdated Show resolved Hide resolved

leongross changed the title ~~[rework] os/SartProcess~~ os/SartProcess Aug 28, 2024

deadprogram reviewed Sep 6, 2024

View reviewed changes

src/os/osexec.go Outdated Show resolved Hide resolved

deadprogram changed the title ~~os/SartProcess~~ os/StartProcess Sep 6, 2024

leongross added 14 commits October 30, 2024 11:40

adjust baremetal build tags

c037cea

Signed-off-by: leongross <[email protected]>

remove old comments

e30e603

os/StartProcess: cleanup

f975bbf

remove old comments, replace explicit syscall numbers with named variants, undo tempfile seed generation, remove old // +build tags, improve StartProcess documentation, remove custom syscall number definitions. Signed-off-by: leongross <[email protected]>

os/exec: exclude aarch64

7f7559c

aarch64 has no support for the fork ssycall. for now exclude it. Signed-off-by: leongross <[email protected]>

add fallback stub for aarch64

fb71295

add syscall error handling

6c6f254

Signed-off-by: leongross <[email protected]>

change build tags aarch64 -> arm64

fdf44d8

Signed-off-by: leongross <[email protected]>

add signal implementations for linux arm64

be48fa5

wip

9b8dd29

update TestForkExec with invalid testcase

6d74b9d

remove comments, remove unused/obsolete files

61267ad

Signed-off-by: leongross <[email protected]>

replace raw syscall implementation with musl wrapper

70bfa96

Signed-off-by: leongross <[email protected]>

remove arm64 handling

5878a4b

Signed-off-by: leongross <[email protected]>

update musl builder to include arch specific process files

706477a

Signed-off-by: leongross <[email protected]>

leongross force-pushed the os/StartProcessOs branch from 230e977 to 706477a Compare October 30, 2024 10:40

add musl sources to release files

664c581

Signed-off-by: leongross <[email protected]>

b0ch3nski reviewed Nov 2, 2024

View reviewed changes

src/os/exec_linux.go Outdated Show resolved Hide resolved

leongross requested review from aykevl and b0ch3nski November 3, 2024 16:05

aykevl reviewed Nov 4, 2024

View reviewed changes

remove redundant else

94e8652

leongross force-pushed the os/StartProcessOs branch from 40487c7 to 94e8652 Compare November 4, 2024 16:38

leongross requested a review from aykevl November 6, 2024 23:11

aykevl merged commit f9f439a into tinygo-org:dev Nov 7, 2024
16 of 17 checks passed

aykevl mentioned this pull request Nov 15, 2024

add os.StartProcess #4323

Closed

deadprogram mentioned this pull request Nov 27, 2024

Feature request: os/exec (execute other executable) #632

Closed

		@@ -0,0 +1,18 @@
		//go:build linux && !baremetal && !darwin && !tinygo.wasm && aarch64

os/StartProcess #4377

os/StartProcess #4377

Uh oh!

Conversation

leongross commented Aug 2, 2024

Uh oh!

aykevl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leongross commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leongross commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aykevl commented Aug 8, 2024

Uh oh!

Uh oh!

Uh oh!

leongross commented Aug 22, 2024

Uh oh!

leongross commented Aug 29, 2024

Uh oh!

Uh oh!

leongross commented Nov 2, 2024

Uh oh!

Uh oh!

aykevl left a comment

Choose a reason for hiding this comment

Uh oh!

aykevl Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

b0ch3nski Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

aykevl Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

aykevl Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

aykevl Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

aykevl Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aykevl commented Nov 7, 2024

Uh oh!

leongross commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leongross commented Aug 5, 2024 •

edited

Loading

leongross commented Aug 8, 2024 •

edited

Loading