UEFI target groundwork: runtime: split baremetal memory setup#5360
Open
sparques wants to merge 1 commit intotinygo-org:devfrom
Open
UEFI target groundwork: runtime: split baremetal memory setup#5360sparques wants to merge 1 commit intotinygo-org:devfrom
sparques wants to merge 1 commit intotinygo-org:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am back with another attempt trying to get UEFI as a target.
Summary:
This PR moves baremetal-specific memory symbol declarations and initialization out of src/runtime/baremetal.go into a separate file, src/runtime/baremetal_memory.go.
The extracted code covers:
Why:
baremetal.go currently mixes general baremetal runtime behavior with the default linker-symbol-based memory layout. Splitting the memory setup into its own file makes that boundary explicit and makes it easier for targets with nonstandard memory initialization to evolve without adding more special cases to the main baremetal runtime file.
For my purposes, eventually baremetal_memory.go will have a
//go:build baremetal && !uefior something to that effect.Behavior:
This is intended to be a pure refactor. There should be no functional change for existing baremetal targets.